Repository navigation
fix(cli): clean up help and next-step guidance - #2626
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
This is a focused UX/copy pass: reorders project commands so add sits next to create, splits commandSection into separate menuSection / helpSection primitives so --help can group commands (Project/Resources/Settings) without affecting the TUI menu, cleans up next-step copy, and renders the TextAreaField example on its own indented line (which now supports multi-line examples, used by the llm-as-a-judge instructions step).
I verified:
- The
TextAreaFieldtest expectations (for example:\n ${EXAMPLE}— three leading spaces on the continuation line) are consistent with the two-space indent infields.tsxplus thepaddingX={1}onStep, including the multi-line case inllm-as-a-judge.screen.test.tsx. root.test.tsx,RouterScreen.test.tsx,CommandFallbackScreen.test.tsx, androuter.test.tswere all updated to match the new ordering/grouping.command.mdregeneration matches the newDEFAULT_GROUPSorder and the parser now understands the three new help section titles.- Dropping
agentcore buildfrom theexport harnessnext-step list is consistent with the project-level comment thatdeployalready runsbuild.
No functional issues, no telemetry gap (this isn't a new feature), and no test smells.
Nits (non-blocking, feel free to ignore):
src/handlers/index.tsx:100-101usesmenuSection("resources")followed immediately byhelpSection("resources");commandSection("resources")would express the same thing.CommandFallbackScreen.test.tsxstill names the test "the root menu retains the dev handoff" even though the top-of-menu assertion is now❯ add. The intent (thatdevis still a reachable screen) is preserved, so the test is fine, just slightly misleadingly named.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2626 +/- ##
=========================================
Coverage 96.61% 96.61%
=========================================
Files 704 704
Lines 58404 58412 +8
=========================================
+ Hits 56429 56437 +8
Misses 1975 1975 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jariy17
left a comment
There was a problem hiding this comment.
Looks good. Thanks for implementing this fit and finish PR.
Description
Apply the DX-001 copy and information-hierarchy fixes without introducing a style guide:
agentcore buildstep fromagentcore export harnessbecauseagentcore deployalready buildsThe root TUI keeps its resource divider behavior while using the same project workflow order.
Visual review
Organized root help
Runtime next steps
LLM-as-a-judge instructions
The exported-harness change only removes the redundant
agentcore buildline, so it is covered by the output assertion rather than a separate screenshot.Related Issue
Closes #2625
Documentation PR
Documentation is included in the regenerated
command.md; no external docs PR is needed.Type of Change
Testing
How have you tested the change?
bun test(311 files, 4,695 tests)bun run test:e2e, or explained why they are not applicable — not applicable; these are deterministic local help, wizard, and guidance surfaces covered by unit/screen testsbun run typecheckbun run lint:checkbun run format:checkbun run buildsrc/assets/, I updated affected snapshots withbun test <test-file> --update-snapshotsand committed them —src/assets/was not modifiedbun run secrets:checkChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.