Skip to content

fix(project): clarify migration and build guidance - #2621

Merged
jariy17 merged 3 commits into
aws:refactorfrom
notgitika:fix/bugbash-project-guidance
Oct 20, 2026
Merged

jariy17 merged 3 commits into
aws:refactorfrom
notgitika:fix/bugbash-project-guidance

Conversation

@notgitika

Copy link
Copy Markdown
Contributor

Summary

  • show a persistent compatibility banner when the v1 CLI opens a v0 project
  • print guidance to use agentcore migrate after direct v0 commands and every TUI exit
  • make the v0 add/remove error point to the migration command
  • clarify the exact agentcore/agentcore.json edits needed to switch a runtime from Container back to CodeZip

Context

This addresses two improvements reported during the CLI v1 bug bash: making v0 compatibility mode unmistakable, and making the vended runtime README migration steps easier to follow.

Related Issue

Bug-bash feedback; no GitHub issue was filed.

Documentation PR

Documentation is included in this PR.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other

Testing

  • I ran bun test — 4,691 tests passed
  • End-to-end tests are not applicable; the behavior is covered by CLI middleware, TUI, deploy, and generated README tests
  • I ran bun run typecheck
  • I ran bun run lint:check
  • I ran bun run format:check
  • I ran bun run build
  • Generated README content is asserted by the affected runtime tests; no snapshot changes were required

Checklist

  • I have read the CONTRIBUTING document
  • I have added tests that prove the fix is effective
  • I have updated the documentation accordingly
  • The vended READMEs include the relevant configuration example
  • My changes generate no new warnings
  • No dependent changes are required

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions Bot added the size/m PR size: M label Oct 19, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Oct 19, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Oct 19, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Nice, focused change. The v0 compatibility notice is wired through consistently:

  • withV0ProjectNotice registered once at the root wraps every command path.
  • The invocation-local V0ProjectNoticeState.enteredTui handoff from middleware → renderTuiAt cleanly avoids double-printing the migration reminder when a TUI session is entered, and the h.name() !== "migrate" guard correctly uses the leaf name (middleware wraps the leaf after the stack is unwound).
  • The TUI's own re-detection fallback in renderTuiAt (when V0ProjectDetectedKey is undefined) keeps direct test uses of renderTuiAt working.
  • README template substitution for {{versions.latestPythonRuntime}} / {{versions.latestNodeRuntime}} is backed by the new fields in runtimeDocsTree.
  • Tests use real temp directories and real IO rather than mocks, which matches the project convention.
  • Telemetry already captures project_format at the top level in src/index.ts, so no new instrumentation is needed for this UX reminder.

No changes requested.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Oct 19, 2026
@codecov-commenter

codecov-commenter commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.61%. Comparing base (ea4fe99) to head (f8beee6).
⚠️ Report is 1 commits behind head on refactor.

Additional details and impacted files
@@            Coverage Diff            @@
##           refactor    #2621   +/-   ##
=========================================
  Coverage     96.61%   96.61%           
=========================================
  Files           702      704    +2     
  Lines         58347    58405   +58     
=========================================
+ Hits          56373    56430   +57     
- Misses         1974     1975    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added size/m PR size: M and removed size/m PR size: M labels Oct 19, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Oct 19, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Oct 19, 2026
nborges-aws
nborges-aws previously approved these changes Oct 19, 2026
tejaskash
tejaskash previously approved these changes Oct 20, 2026
@notgitika
notgitika dismissed stale reviews from tejaskash and nborges-aws via f8beee6 October 20, 2026 15:00
@github-actions github-actions Bot added size/m PR size: M and removed size/m PR size: M labels Oct 20, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Oct 20, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Oct 20, 2026
@notgitika

Copy link
Copy Markdown
Contributor Author

Updated TUI placement: the v0 compatibility notice now uses the warning alert directly below the command input and above dev.

Updated v0 project compatibility warning

@jariy17
jariy17 merged commit aa5a559 into aws:refactor Oct 20, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m PR size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants