Repository navigation
fix(project): clarify migration and build guidance - #2621
Merged
Merged
Conversation
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Nice, focused change. The v0 compatibility notice is wired through consistently:
withV0ProjectNoticeregistered once at the root wraps every command path.- The invocation-local
V0ProjectNoticeState.enteredTuihandoff from middleware →renderTuiAtcleanly avoids double-printing the migration reminder when a TUI session is entered, and theh.name() !== "migrate"guard correctly uses the leaf name (middleware wraps the leaf after the stack is unwound). - The TUI's own re-detection fallback in
renderTuiAt(whenV0ProjectDetectedKeyis undefined) keeps direct test uses ofrenderTuiAtworking. - README template substitution for
{{versions.latestPythonRuntime}}/{{versions.latestNodeRuntime}}is backed by the new fields inruntimeDocsTree. - Tests use real temp directories and real IO rather than mocks, which matches the project convention.
- Telemetry already captures
project_formatat the top level insrc/index.ts, so no new instrumentation is needed for this UX reminder.
No changes requested.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2621 +/- ##
=========================================
Coverage 96.61% 96.61%
=========================================
Files 702 704 +2
Lines 58347 58405 +58
=========================================
+ Hits 56373 56430 +57
- Misses 1974 1975 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
nborges-aws
previously approved these changes
Oct 19, 2026
tejaskash
previously approved these changes
Oct 20, 2026
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
Author
jariy17
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
agentcore migrateafter direct v0 commands and every TUI exitagentcore/agentcore.jsonedits needed to switch a runtime from Container back to CodeZipContext
This addresses two improvements reported during the CLI v1 bug bash: making v0 compatibility mode unmistakable, and making the vended runtime README migration steps easier to follow.
Related Issue
Bug-bash feedback; no GitHub issue was filed.
Documentation PR
Documentation is included in this PR.
Type of Change
Testing
bun test— 4,691 tests passedbun run typecheckbun run lint:checkbun run format:checkbun run buildChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.