fix(bma): rename environment template and skip unsupported dev - #2501
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
The rename from bedrock-managed-agents → environment-python-bma is applied consistently across schemas, shortcuts, resolvers, scaffolding, screens, help, and tests. The classification helper isBmaRuntime correctly covers both the tag and the policy fallback, so legacy specs are still recognized. The dev-handler logic is sound:
selectRuntimesthrowsResourceNotFoundErrorwhen a user-named runtime doesn't exist, andNotImplementedError(withsource: USER, exit 1) when the only matches are BMA.- Mixed sessions log a skip for each BMA runtime and continue with the supported ones; reload paths filter the same way.
- The
NotImplementedErrorconstructor change (letting callers overridesourcevia a spread) is backward-compatible — existing callers still default toINTERNAL.
A couple of small things I noticed but which don't warrant changes:
- The "Skipping runtime 'X'" status is emitted for every BMA runtime in the project even when the user passed
--agentfor a specific supported runtime; slightly noisy but harmless. - The
NotImplementedErrormessage hard-codesenvironment-python-bma, even though a runtime can be classified as BMA purely via the policy file (not the tag). In the rare "configured BMA by hand" case the message names a template the user didn't use. Not worth fixing.
No blocking issues. Nothing new to flag beyond the prior discussion.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2501 +/- ##
=========================================
Coverage 97.39% 97.40%
=========================================
Files 642 642
Lines 46839 46862 +23
=========================================
+ Hits 45620 45644 +24
+ Misses 1219 1218 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fair callout. Updating now to avoid the noise.
I don't think customers could / would hand roll this template, so I think we are okay here. |
5736112 to
8e12d14
Compare
|
Claude Security Review: no high-confidence findings. (run) |
aidandaly24
left a comment
There was a problem hiding this comment.
This looks good to me
| runtime.tags?.[BMA_TEMPLATE_TAG_KEY] === BMA_TEMPLATE_TAG_VALUE || | ||
| runtime.additionalPolicies?.includes(BMA_POLICY_FILE), | ||
| ); | ||
| const bmaRuntimes = project.spec.runtimes.filter(isBmaRuntime); |
| `Runtime '${name}' was not found. Available runtimes: ${available}.`, | ||
| ); | ||
| } | ||
| const supportedRuntimes = selectedRuntimes.filter(supportsLocalDev); |
There was a problem hiding this comment.
Nice and this function gives us flexibility in the future if theres more runtimes like this
Problem
bedrock-managed-agentswhich doesn't match the existing pattern.Solution
environment-python-bmaacross scaffolding, TUI choices, and help.NotImplementedErrorandsource: "user".Verification
Verified with the compiled Linux CLI:
environment-python-bma; the wizard screenshot is retained locally.demo-bma.mov