Skip to content

test(e2e): wait for batch evaluation before archiving #2499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aidandaly24 merged 1 commit into from
Oct 1, 2026
Merged

test(e2e): wait for batch evaluation before archiving #2499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions e2e-tests/archive-lifecycle.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ describe.sequential('e2e: archive command lifecycle', () => {
// ════════════════════════════════════════════════════════════════════════

it.skipIf(!canRun)(
'runs batch evaluation and captures the ID',
'waits for batch evaluation to finish and captures the ID',
async () => {
await retry(
async () => {
Expand All @@ -129,6 +129,7 @@ describe.sequential('e2e: archive command lifecycle', () => {
'Builtin.Faithfulness',
'--lookback-days',
'1',
'--wait',
'--json',
]);
expect(result.exitCode, `batch-evaluation failed (stdout: ${result.stdout}, stderr: ${result.stderr})`).toBe(
Expand All @@ -137,7 +138,7 @@ describe.sequential('e2e: archive command lifecycle', () => {
const json = parseJsonOutput(result.stdout) as Record<string, unknown>;
expect(json).toHaveProperty('success', true);
expect(json.id).toBeTruthy();
expect(json.status).not.toBe('FAILED');
expect(['COMPLETED', 'COMPLETED_WITH_ERRORS', 'STOPPED']).toContain(json.status);

@Hweinstock Hweinstock Oct 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is completed with errors acceptable?

@aidandaly24 aidandaly24 Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for this archive lifecycle test. COMPLETED_WITH_ERRORS is terminal, and the service explicitly permits deleting it.

We’re testing successful archive and local-record cleanup, not evaluation correctness. The previous assertion only excluded FAILED, so it already accepted COMPLETED_WITH_ERRORS.

A test validating evaluation results should require COMPLETED and inspect the results.

batchEvaluationId = json.id as string;
},
6,
Expand Down
Loading