chore(tests): split custom Vitest matchers out of setupEnv - #5704
Merged
Merged
Conversation
Move the AWS SDK, Logger and Metrics matchers into one module each under packages/testing/src/matchers, keeping each family's implementation next to its assertion typings. setupEnv keeps its path and only registers the merged object.
powertools-for-aws-oss-automation
Bot
added
the
size/XL
dreamorosi
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the AWS SDK, Logger, and Metrics matchers out of the shared test setup, keeping each family's implementation alongside its assertion typings. Existing matcher behavior and the shared
setupEnv.tsentry point are preserved.Changes
awsSdk.ts,logger.ts, andmetrics.tsunderpackages/testing/src/matchers/.matchers/index.ts, with registration performed bysetupEnv.ts.Issue number: closes #5697
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.