Skip to content

fix(event-handler): handle empty proxy response bodies - #5701

Merged
dreamorosi merged 1 commit into
mainfrom
fix/5699-empty-response-body
Sep 13, 2026
Merged

dreamorosi merged 1 commit into
mainfrom
fix/5699-empty-response-body

Conversation

@svozza

@svozza svozza commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Returning { statusCode: 204, body: '' } caused the router to return 500 because the Web Response constructor rejects a non-null body for statuses 204, 205, and 304. Empty proxy-result strings now become null before construction, preserving the requested status and empty response body.

Changes

  • Normalize empty strings alongside null and omitted proxy-response bodies.
  • Add buffered regressions across REST API, HTTP API, and ALB, plus streaming and empty base64-body coverage.
  • Verify status 200 and omitted-body responses continue to work.
  • Validate workspace test types, staged-file linting, and the unit suite with 100% coverage.

Issue number: closes #5699


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

dreamorosi
dreamorosi previously approved these changes Sep 12, 2026
@dreamorosi
dreamorosi merged commit 9f39aef into main Sep 13, 2026
41 checks passed
@dreamorosi
dreamorosi deleted the fix/5699-empty-response-body branch September 13, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M PR between 30-99 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Empty proxy response bodies turn HTTP 204, 205, and 304 into 500

2 participants