feat[kafka]: avro offline schema handling - #8442
Conversation
82b5409 to
e9c5f67
Compare
|
I'm reviewing this. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8442 +/- ##
========================================
Coverage 96.64% 96.65%
========================================
Files 296 296
Lines 14773 14806 +33
Branches 1248 1255 +7
========================================
+ Hits 14277 14310 +33
Misses 361 361
Partials 135 135 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hi Amin, I reviewed the implementation and tested the cases we discussed in the issue. The overall work is very good. The use case is clear, the API direction makes sense, and the implementation was close to complete. Instead of adding several review comments, I made the final changes directly in your branch with commit I preserved compatibility for positional All 44 Kafka functional tests pass, together with Ruff, mypy, and the documentation build. The new parameters remain optional, so this does not break the current API. I am going to merge the PR. |
|
|
Tick the box to add this pull request to the merge queue (same as
|



Issue number: closes #8385
Summary
Changes
Added a
value_schema_wire_formatarguement to theSchemaConfigof Kafka utility, enabling the use of local (packaged with lambda) AVRO value schema for payloads generated by schama-registery aware Confluent producers (i.e. payloads serialised byKafkaAvroSerializer).User experience
An optional argument has been added to
SchemaConfig. Documentation has been updated, showing how and when this argument can be used.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.