Skip to content

fix(android): skip explicit Kotlin plugin when AGP registers the kotlin extension - #1654

Merged
subhankarmaiti merged 1 commit into
auth0:masterfrom
gabrieldonadel:fix/agp9-built-in-kotlin-auth0
Sep 7, 2026
Merged

subhankarmaiti merged 1 commit into
auth0:masterfrom
gabrieldonadel:fix/agp9-built-in-kotlin-auth0

Conversation

@gabrieldonadel

Copy link
Copy Markdown
Contributor

Problem

Android Gradle Plugin 9 ships built-in Kotlin support and enables it by default, so
AGP registers the kotlin extension itself. When a library also applies kotlin-android
explicitly, the two collide and configuration fails before anything compiles. AGP
words it two ways, both the same problem:

> Failed to apply plugin 'kotlin-android'.
   > Cannot add extension with name 'kotlin', as there is an extension already registered with that name.
> The 'kotlin-android' plugin is no longer required for Kotlin support since AGP 9.0.

The apply is unconditional in this module, so on an AGP 9 project this cannot be built
at all. There is no consumer-side workaround short of patching the file — setting
android.builtInKotlin=false project-wide just to build one dependency is not a
reasonable ask, and that escape hatch is removed in AGP 10.

Change

Apply the plugin only when nothing has registered the kotlin extension yet:

if (project.extensions.findByName('kotlin') == null) {
    apply plugin: 'kotlin-android'
}

Files changed:

  • android/build.gradle

This tests the condition that actually fails, so there is no AGP version table to
keep in sync, and it covers AGP 10 — where the android.builtInKotlin opt-out is
removed — without a special case.

AGP android.builtInKotlin kotlin extension explicit apply
8.x unset or false absent yes (unchanged)
9.x unset or true registered by AGP no
9.x false absent yes
10+ n/a (removed) registered by AGP no

The guard sits after apply plugin: 'com.android.library' in every file it touches,
so AGP has already registered its extensions by the time it runs. I checked that
ordering per file rather than assuming it.

What I verified, and what I did not

  • Verified end to end on a real Expo SDK 58 / React Native 0.87 project with AGP
    9.2.1 and Gradle 9.4.1: :app:assembleDebug succeeds both with
    -Pandroid.newDsl=true -Pandroid.builtInKotlin=true and with both flags off.
  • Confirmed both branches actually execute rather than one path always winning: with
    the flags off, compileDebugKotlin runs from the explicitly applied plugin; with
    them on the build completes without it.
  • Every changed file passes a Groovy Phases.CONVERSION syntax check.
  • Not run: this repo's own CI or example app.

Where this came from

A sweep of 1000 popular React Native libraries against the AGP 9 defaults. 281 failed
with the new DSL enabled, and 269 of those failed on exactly this collision — by
far the most common blocker. Affects react-native-auth0 here.

The same guard shape was accepted in
RevenueCat/react-native-purchases#1934,
at that maintainer's suggestion.

@gabrieldonadel
gabrieldonadel requested a review from a team as a code owner September 5, 2026 15:57
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 344e2e09-e760-4c00-b75e-af6fc0607589

📥 Commits

Reviewing files that changed from the base of the PR and between a429269 and b71202c.

📒 Files selected for processing (1)
  • android/build.gradle

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Improved Android build compatibility with newer Android Gradle Plugin versions by preventing duplicate Kotlin plugin registration.

Walkthrough

The Android build script now applies kotlin-android only when the kotlin extension is not already registered.

Changes

Android build configuration

Layer / File(s) Summary
Conditional Kotlin plugin registration
android/build.gradle
The script checks for the existing kotlin extension before applying the kotlin-android plugin.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to b56ae

Android builds now avoid reapplying the Kotlin plugin when AGP has already registered Kotlin support, while retaining the previous behavior otherwise. No current merge-blocking risk remains.

Suggested reviewers: subhankarmaiti

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: skipping the explicit Kotlin plugin when AGP registers the kotlin extension.
Description check ✅ Passed The description directly explains the AGP 9 conflict, the conditional plugin application, compatibility behavior, and verification performed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@subhankarmaiti

Copy link
Copy Markdown
Contributor

Thanks @gabrieldonadel for opening the PR, can you please verify your commit

…in extension

AGP 9 ships built-in Kotlin support and registers the kotlin extension
itself. Applying the Kotlin plugin again fails configuration with
"Cannot add extension with name 'kotlin'". Check for the extension
directly, which needs no AGP version table and covers AGP 10, where the
android.builtInKotlin opt-out is removed.
@gabrieldonadel
gabrieldonadel force-pushed the fix/agp9-built-in-kotlin-auth0 branch from b71202c to b56ae15 Compare September 7, 2026 15:53
@gabrieldonadel

Copy link
Copy Markdown
Contributor Author

Thanks @gabrieldonadel for opening the PR, can you please verify your commit

Done

@subhankarmaiti
subhankarmaiti merged commit b049a8a into auth0:master Sep 7, 2026
4 of 6 checks passed
@subhankarmaiti subhankarmaiti mentioned this pull request Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants