Bench: Update channel authentication - #856
Merged
Merged
Conversation
ao-david
force-pushed
the
update-channel-auth
branch
from
September 30, 2026 03:27
6974c22 to
a4160df
Compare
elliot-ausocean
approved these changes
Sep 30, 2026
elliot-ausocean
left a comment
elliot-ausocean
left a comment
Collaborator
There was a problem hiding this comment.
Looks good other than a few nits.
| and broadcast scheduling. | ||
|
|
||
| AUTHORS | ||
| Saxon Nelson-Milton <saxon@ausocean.org> |
Collaborator
There was a problem hiding this comment.
Is this file new or did it get lost? If it is new, is this list of authors correct?
Member
Author
There was a problem hiding this comment.
This is a new file, but with most of the functions copied/heavily inspired by the existing files, so I gave credit.
| return fmt.Errorf("unable to set token-url value in oauth flow session: %w", err) | ||
| } | ||
|
|
||
| maxAge := 10 * 60 // 10 minutes |
Collaborator
There was a problem hiding this comment.
This could be moved above oauthFlowSession.SetMaxAge so that they both use the same value.
Member
Author
There was a problem hiding this comment.
I was supposed to remove the first call to setMaxAge, which I have now done
ao-david
force-pushed
the
update-channel-auth
branch
from
September 30, 2026 03:37
a4160df to
7940430
Compare
This change updates the channel authentication to correctly register the callback handler, whilst also cleaning up the pipeline.
ao-david
force-pushed
the
update-channel-auth
branch
from
September 30, 2026 03:37
7940430 to
c72989e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the channel authentication to correctly register the callback handler, whilst also cleaning up the pipeline.