datablue: escape variable values, oceantv+storage: misc fixes - #855
Merged
Merged
Conversation
This change adds JSON escaping to variable values on the vars endpoint of datablue. JSON payloads are created using string concatenation for some reason in this function (I am guessing one of the netsenders is fussy with its parsing) and I am leaving it be in case something downstream breaks. The OceanMedia broadcast host now returns a pointer instead of a value for zero arg initialisations so that the BroadcastHost interface is satisfied. BroadcastEvent and Notification are added to the oceantv composite store mapping to allow oceantv to work with these models. A couple of missed fields are added to the cloudflare temporary authentication JWT and the secret key is hex encoded instead of outputting as a raw string. With this PR and the associated PR in prod, the streaming side of OceanMedia is functional.
elliot-ausocean
force-pushed
the
pr855
branch
from
September 29, 2026 00:23
aab3139 to
d45de68
Compare
ao-david
approved these changes
Sep 29, 2026
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds JSON escaping to variable values on the vars endpoint of datablue. JSON payloads are created using string concatenation for some reason in this function (I am guessing one of the netsenders is fussy with its parsing) and I am leaving it be in case something downstream breaks. The OceanMedia broadcast host now returns a pointer instead of a value for zero arg initialisations so that the BroadcastHost interface is satisfied. BroadcastEvent and Notification are added to the oceantv composite store mapping to allow oceantv to work with these models. A couple of missed fields are added to the cloudflare temporary authentication JWT and the secret key is hex encoded instead of outputting as a raw string. With this PR and the associated PR in prod, the streaming side of OceanMedia is functional.