fix(protocol): preserve initial login packets - #551
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This was referenced Sep 24, 2026
zoeyrose
marked this pull request as ready for review
September 24, 2026 17:58
7 tasks
zoeyrose
added a commit
to atrinik/devcontainer
that referenced
this pull request
Sep 24, 2026
## Summary Pin the portable Classic consumer to the merged login and notification fixes from atrinik/classic#551. ## Implementation / behavior - Use merged Classic source `d926f6fd0418fb1af9060158c43d8d3ff5252580` in `portable/contract.json`. - Preserve the existing Debian baseline, canonical shader tools, source and license verification, and normal publication workflow. ## Validation The existing portable validation and real offline consumer jobs must pass for this exact producer head. Final local and CI evidence will be recorded before readiness. ## Limitations / follow-up Immutable image and platform digests become available after maintainer merge and successful normal semantic-release publication. Wrapper atrinik/atrinik#615 consumes those published identities. Closes #50 <!-- atrinik-delivery:body:da576fe5aa12e12dc4b268588209575ad66b327f67bc1c8eae511d7a14eea736:start --> ## Delivery validation Reviewed head: `0b268a4beb6f3b847728fed16c47c1618be39050`. - Final-head local checks passed: 11 portable ABI tests, 21 dependency/shader/Vulkan tests, required-check aggregation tests, and `git diff --check`. - [Normal portable validation run](https://github.com/atrinik/devcontainer/actions/runs/36064725484) passed Dockerfile checks, the non-root baseline smoke, and all 83 offline Classic consumer tests. The retained artifact confirms Classic `d926f6fd0418fb1af9060158c43d8d3ff5252580`, glibc 2.36, and generic x86-64 compiler flags across 274 compile units. - Independent whole-diff review found zero actionable issues. CodeQL, PR-title policy, and the required aggregate passed. Unaffected Linux, Classic CI, and Windows image jobs were skipped by the existing path selector. - This is CPU-only build/consumer evidence. It does not establish hardware GPU gameplay qualification. The published image index/platform digests remain pending maintainer merge and the normal semantic-release publication workflow. No manual release or registry publication was performed. <!-- atrinik-delivery:body:da576fe5aa12e12dc4b268588209575ad66b327f67bc1c8eae511d7a14eea736:end -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct initial-login item ordering and notification delay decoding, and expose existing notification/mapstats command constants to the embedded Python module.
Implementation / behavior
Keep item updates behind their initial introduction, read the notification delay once before clamping, and export generated command identifiers without changing the wire contract. Focused regressions cover the production paths and malformed input.
Validation
Validation results will be recorded after focused before/after regressions, pinned container builds and tests, and independent whole-diff review.
Limitations / follow-up
Offline validation does not complete real gameplay qualification. Runtime owner atrinik/atrinik#604 repeats that qualification after maintainer merge. Authored content remains a separate delivery.
Closes #550
Final validation and review
The final commit is
0058d6a904386c86b3f06844c66d9273baca6f9e.PLAYERand the own-inventory snapshot, and after that snapshot. A different-container snapshot does not establish the initial inventory. The own snapshot's target and item contents are checked.CLIENT_CMD_NOTIFICATION=26andCLIENT_CMD_MAPSTATS=12.NDEBUG. This fixes the initially observed Release-only test-link failure.git diff --checkpass.Earlier diagnostic runs exposed the intended regressions and two subsequently fixed test compilation issues. Failed tooling invocations and reporting attempts remain retained as failures; they are not counted as passing acceptance runs. A historical local formatter resource-planning violation is disclosed in the private delivery record; all final acceptance uses the subsequently reviewed container composition.
Real GPU/audio/gameplay qualification remains with atrinik/atrinik#604 after maintainer merge and verified artifact refresh. The separately owned authored-content correction is atrinik/content#264. This PR does not modify authored content, change wire IDs, or claim live gameplay qualification.