You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Replace the micro-package @xterm/addon-fit with the in-tree fitTerminal helper.
Preserve xterm's sizing behavior, including CSS padding, overview-ruler allowance, minimum geometry, and render invalidation.
Keep initial-frame, window-resize, fullscreen, and container-observer refits wired through the shell session hook.
Remove the dependency from the client manifests and record it as removed in docs/DEPS.md.
Test plan
npm test -- src/lib/terminalFit.test.js src/lib/index.test.js src/hooks/useShellSession.test.jsx — 40 passed
npm run lint — passed
npm run build — passed
Full client suite — 11,444 passed, 7 skipped; one unrelated existing VideoTimelineEditor loading-state test failed while its localhost:3000 service was unavailable
Required code review was not completed before publication. This PR is intentionally left open and will not be merged until the required review completes.
Review-loop status: Antigravity (gemini-3.8-flash, optional, maximum one round) is inconclusive (no-verdict, zero review invocations). command -v agy confirmed the binary is installed; its installed --help provides neither an invocation-local isolated-settings selector nor an enforced empty tool set with MCP/hooks/plugins disabled. No PR content was supplied to an unrestricted reviewer, and no substitute review was performed. This follow-up explicitly permits an inconclusive optional review to proceed. No existing review findings or unresolved review threads were present. The original CI gates failed because selected test jobs were cancelled; the complete CI run has been restarted and must pass before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@xterm/addon-fitwith the in-treefitTerminalhelper.docs/DEPS.md.Test plan
npm test -- src/lib/terminalFit.test.js src/lib/index.test.js src/hooks/useShellSession.test.jsx— 40 passednpm run lint— passednpm run build— passedVideoTimelineEditorloading-state test failed while its localhost:3000 service was unavailableCloses #7014