Skip to content

test: make killWithEscalation unref regression detectable (#7016) - #7076

Merged
atomantic merged 1 commit into
mainfrom
claim/issue-7016
Sep 12, 2026
Merged

test: make killWithEscalation unref regression detectable (#7016)#7076
atomantic merged 1 commit into
mainfrom
claim/issue-7016

Conversation

@atomantic

Copy link
Copy Markdown
Owner

Summary

Test plan

  • ./node_modules/.bin/vitest run lib/killWithEscalation.test.js (8 passed)
  • Mutation probe with timer.unref?.() disabled (1 expected failure), then restored
  • Four previously timing-sensitive server files with --testTimeout=30000 (346 passed)
  • npm test --prefix server (2164 files passed, 4 unrelated 10s timeout failures under the full-suite load)

The full-suite timeout failures are in jsonWritebackConventions.test.js, lib/eidoverseCitySurface.test.js, lib/validationSplit.test.js, and services/sharing/peerSync.test.js; all four pass independently with the higher timeout.

@atomantic
atomantic merged commit 7c8a618 into main Sep 12, 2026
7 checks passed
@atomantic
atomantic deleted the claim/issue-7016 branch September 12, 2026 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[test-quality-kill-with-escalation-unref] killWithEscalation unref test only asserts timer is defined, missing event loop leak regression

1 participant