Skip to content

test: validate milestone completion timestamp (#7017) - #7074

Merged
atomantic merged 2 commits into
mainfrom
claim/issue-7017
Sep 12, 2026
Merged

test: validate milestone completion timestamp (#7017)#7074
atomantic merged 2 commits into
mainfrom
claim/issue-7017

Conversation

@atomantic

Copy link
Copy Markdown
Owner

Summary

  • Strengthen milestone completion coverage so a completed milestone must include a non-null timestamp.
  • Verify the returned value is a string containing a parseable timestamp.

Tests

  • npm test --prefix server -- services/identity.test.js -t "should complete a milestone"
  • npm test --prefix server -- services/identity.test.js
  • Mutation probe: disabling the production timestamp assignment failed the test as expected.

Closes #7017

@atomantic
atomantic merged commit b605a8b into main Sep 12, 2026
7 checks passed
@atomantic
atomantic deleted the claim/issue-7017 branch September 12, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[test-quality-identity-complete-milestone-null-defined] completeMilestone test uses toBeDefined on nullable completedAt, passing when timestamp is null

1 participant