Skip to content

test: validate goal progress timestamp format (#7019) - #7073

Merged
atomantic merged 2 commits into
mainfrom
claim/issue-7019
Sep 12, 2026
Merged

test: validate goal progress timestamp format (#7019)#7073
atomantic merged 2 commits into
mainfrom
claim/issue-7019

Conversation

@atomantic

Copy link
Copy Markdown
Owner

Summary

  • Replace the vacuous instanceof Date assertion with explicit non-null, string, parseability, and canonical ISO timestamp checks.

Test plan

  • ./node_modules/.bin/vitest run services/goalProgress.test.js
  • Mutation probes for invalid text and null timestamps both fail the focused test as expected.

Closes #7019

@atomantic
atomantic merged commit 08df85b into main Sep 12, 2026
7 checks passed
@atomantic
atomantic deleted the claim/issue-7019 branch September 12, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[test-quality-goal-progress-instanceof-date-tautology] goalProgress test asserts new Date(updatedAt) instanceof Date, passing on invalid dates and null

1 participant