fix: promote spinning refresh icon to its own layer on Usage page - #7072
Merged
Conversation
The subscription usage page's refresh icons toggle animate-spin on and off frequently (the section-level Refresh All, and each provider card's per-family refresh, which also restarts on every pending poll). Without a compositor-layer hint, the browser can leave a stale rasterized frame behind the live rotation on repeated restarts, making the spin look like it's rendering over a static duplicate of itself. will-change-transform forces the icon onto its own GPU layer so the restart repaints cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
animate-spinon and off frequently — the section-level refresh, plus the per-card poll that auto-refreshes while a reading is pending.will-change-transformto bothRefreshCwicons so the browser promotes them to their own GPU layer before the spin starts, avoiding the artifact.Test plan
cd client && npx vitest run src/pages/UsagePage.test.jsx— 16/16 pass, unchanged./api/**calls mocked (playwright), navigated to/devtools/usage, clicked Refresh All, and confirmed the button renders exactly oneRefreshCwSVG with a single continuousanimate-spinanimation (element.getAnimations()), no pseudo-element or duplicate icon in the DOM.