fix: deduplicate Three.js while preserving package exports - #7068
Conversation
|
CI remains blocked after a failed-job rerun. Both attempts fail in the existing server/lib/importScoping.test.js budget assertion (103,592 static module instantiations vs the 103,240 cap), which then cancels the sibling jobs. This PR changes only client/vite.config.js and client/vitest.config.js, so I did not weaken or broaden the fix to mask the unrelated server-suite regression. The PR is intentionally left open for that CI blocker to be resolved; the issue claim and branch remain in place. |
|
Claude review completed its configured 1/1 round with exit 0 using enforced Read/Glob/Grep-only tools, plan mode, disabled hooks/MCP/Chrome, and safe/restricted mode. The working tree remained unchanged. Status: no-verdict (optional, inconclusive) because stdout included a prose preamble rather than only the required verdict blocks. I evaluated the reported suggestions: mapped Three.js subpaths and hoisted installations are hypothetical for this change; current first-party code and the installed fiber/drei/three-stdlib sources have no CI's cancellation was caused by the server import budget (103,592 against 103,240), not the client alias change. Merged current main, which already includes import narrowing; |
|
The next full CI run supplied a concrete regression that the first targeted avatar test missed: Claude remains recorded as optional/no-verdict, 1/1 rounds consumed; the proposed resolution fix is now applied and independently verified. No additional reviewer round is requested under the configured cap. |
Keep 3D components and helper libraries on one Three.js module instance using
resolve.dedupein Vite and Vitest. This preserves package exports and fixes the directory alias regression whereRoomEnvironmentfailed the existinginstanceof THREE.Sceneassertion.Validation: seven focused Three.js/avatar test files; client production build; server import-scoping suite (68 tests) after merging current main to pick up its existing import-budget fix. Full CI must pass before merge.
Closes #7066