feat: expand safety model with scope, side effects, confirmation (#87) - #132
Merged
Merged
Conversation
Add PermissionScope, side_effects, and requires_confirmation on ToolContract with backward-compatible defaults. Diff emits escalation / confirmation codes; capture accepts annotations without inventing values; probes support max_scope and forbidden_side_effects. Co-authored-by: Abhinaysai Kamineni <askmy-stack@users.noreply.github.com>
askmy-stack
marked this pull request as ready for review
September 18, 2026 18:22
Co-authored-by: Abhinaysai Kamineni <askmy-stack@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expands the safety model beyond a single
riskenum (#87):PermissionScope(resource…global, plusunknown)side_effectslist (open vocabulary; documented common tags)requires_confirmation: bool | None(null= undeclared)tool.scope_escalated/scope_changed,side_effect_added/removed,confirmation_removed(critical for true→false) /addedannotations— never invents valuesmax_scope,forbidden_side_effectsdocs/safety.md, change-codes catalog, SECURITY.md noteType of change
Test plan
ruff/mypy/pytest(escalation, confirmation removed, probe gates, manifest capture)Closes #87