Repository navigation
Use inline hints - #100
Open
krokosik wants to merge 10 commits into
Open
Use inline hints#100krokosik wants to merge 10 commits into
krokosik wants to merge 10 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
+ Coverage 91.36% 91.81% +0.44%
==========================================
Files 6 7 +1
Lines 869 916 +47
==========================================
+ Hits 794 841 +47
Misses 75 75 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Documentation build overview
15 files changed ·
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the project's Python version constraint being >=3.12, it is safe to modernize the type hint infrastructure a bit. In particular, there is no need to maintain stub files and code separately and using inline hints is in general much more pleasant to work with.
It also eliminates drift, such as for the linalg accessor, which had all of its stubs untyped (or rather incomplete), causing lots of typing issues downstream. This PR migrates to using stricter types and inline type hints. Happy to discuss more and make adjustments if required :)