Repository navigation
Skip regex parse for bare-newline grammar lines - #10
Merged
Merged
Conversation
Past line 0 a bare newline matches no pattern, so replay it in the current style with an unchanged boundary instead of running Oniguruma. Blank-rich inputs measure ~4% faster; dense inputs within noise. Outputs byte-identical (14 adversarial cases incl. blank lines inside strings/comments, CRLF, unclosed constructs). Co-Authored-By: ace <bot@acehq.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bare
\n/\r\npast line 0 carries no matchable text: skip the Oniguruma search, replay the line in the current style, keep the boundary. Line 0 always parses (first_line meta scope); whitespace-only lines excluded (trailing-space rules). Blank-rich inputs ~4% faster; dense 200-line fixture within noise (cold +2%, mid-edit +2-4% — fixture has zero bare newlines so the skip never fires there). Outputs byte-identical on 14 adversarial cases; full default + grammars suites green.