Repository navigation
ci(seo): audit an indexable tool instead of intentionally noindex BMI - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
PR #25's consolidated Lighthouse run (41637032227) completed successfully as a job, but Lighthouse assertions reported SEO score 0.66 < 0.90 on
/en/tools/bmi-calculatorin all 3 attempts. The BMI tool is intentionallynoindexunder currentCORE_TOOLS_BY_DEMANDpruning policy, and noindex is Lighthouse's expected SEO-score deduction. This is a test target problem, not evidence to reverse the intentional SEO policy.Fix
Change the Lighthouse tool URL to
/en/tools/workdays-calculator(an explicitly indexed tool), retaining homepage and the same performance/accessibility/SEO assertions. No application behavior changed.CI pending. Lighthouse remains
continue-on-error: trueand its assertion output must be checked explicitly. PR #25 main deployment is separate.