FIX: Make showLoadMore button keyboard accessible across list components - #2338
Open
Talha12Shiekh wants to merge 1 commit into
Open
FIX: Make showLoadMore button keyboard accessible across list components#2338Talha12Shiekh wants to merge 1 commit into
Talha12Shiekh wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Ensures that the "Show more" / "Load more" button is fully keyboard-focusable and interactive across all ReactiveSearch list components:
tabIndex={0}): AddedtabIndex={0}to the load-more<Button>components inMultiList.js,SingleList.js,MultiDropdownList.js, andSingleDropdownList.js.onKeyPress): Created ahandleKeyPresshandler in each component that listens forEnterandSpacekey presses, prevents the default scrolling behavior, and triggershandleLoadMore().Linked Issues
MultiList: showLoadMore button is not focusable or triggerable via keyboard)Checklist
Improvements to the Library Experience
Side Effects
Testing
yarn build).