Skip to content

aisix: support Deployment metadata annotations #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JensErat wants to merge 1 commit into from
Closed

aisix: support Deployment metadata annotations #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/aisix/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,7 @@ rejects. New installs set the value in its own key in `values.yaml` or under
| admin.service.annotations | object | `{}` | Extra annotations for the admin Service |
| admin.service.port | int | `3001` | Admin Service port |
| affinity | object | `{}` | Affinity rules for the gateway pods |
| annotations | object | `{}` | Extra annotations for the Deployment |
| autoscaling.behavior | object | `{}` | `spec.behavior` for the HPA. Empty uses the Kubernetes defaults (immediate scale-up, 5-minute scale-down stabilization). A gateway that carries long streaming responses usually wants a gentler scale-down, e.g. `scaleDown: {policies: [{type: Pods, value: 1, periodSeconds: 60}]}` |
| autoscaling.enabled | bool | `false` | Create a HorizontalPodAutoscaler for the gateway Deployment |
| autoscaling.extraMetrics | list | `[]` | Extra `spec.metrics` entries appended verbatim — Pods / Object / External metrics such as a Prometheus adapter series |
Expand Down
4 changes: 4 additions & 0 deletions charts/aisix/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: {{ include "aisix.fullname" . }}
{{- with .Values.annotations }}
annotations:
{{- toYaml . | nindent 4 }}
{{- end }}
labels:
{{- include "aisix.labels" . | nindent 4 }}
{{- include "aisix.selectorLabels" . | nindent 4 }}
Expand Down
2 changes: 2 additions & 0 deletions charts/aisix/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,6 +588,8 @@ extraVolumes: []
# -- Extra volume mounts for the gateway container
extraVolumeMounts: []

# -- Extra annotations for the Deployment
annotations: {}
# -- Annotations for the gateway pods
podAnnotations: {}
# -- Labels for the gateway pods
Expand Down