Skip to content

[ZEPPELIN-6486] Rename the mislabeled "Set up JDK 8" CI step to JDK 11 - #5382

Open
huiseong29 wants to merge 1 commit into
apache:masterfrom
huiseong29:ZEPPELIN-6486
Open

[ZEPPELIN-6486] Rename the mislabeled "Set up JDK 8" CI step to JDK 11#5382
huiseong29 wants to merge 1 commit into
apache:masterfrom
huiseong29:ZEPPELIN-6486

Conversation

@huiseong29

Copy link
Copy Markdown

What is this PR for?

The JDK setup step in the flink-test-and-flink-integration-test job of .github/workflows/core.yml was named "Set up JDK 8" while its java-version was already set to 11. The name was the only thing wrong; anyone reading the workflow or the CI logs would think the job runs on JDK 8.

This renames the step to "Set up JDK 11", matching the correctly labeled step elsewhere in the same file. Only the display name changes — java-version and every other key stay exactly as they are.

A grep across .github/workflows/ confirms this was the only static JDK setup step whose name disagreed with its configured java-version; every other step either pins 11 with a matching name or derives the version from the build matrix.

What type of PR is it?

Improvement

Todos

  • - Rename the step to "Set up JDK 11"

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-6486

How should this be tested?

grep -rn "Set up JDK 8" .github/workflows/ returns no matches.
The renamed step still has java-version: 11 and no other keys changed.
The workflow YAML still parses.

Screenshots (if appropriate)

N/A

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

### What is this PR for?
The JDK setup step in the flink-test-and-flink-integration-test job of
.github/workflows/core.yml was named "Set up JDK 8" while its
java-version was already set to 11. The name was the only thing wrong;
anyone reading the workflow or the CI logs would think the job runs on
JDK 8.

This renames the step to "Set up JDK 11", matching the correctly labeled
step elsewhere in the same file. Only the display name changes.

A grep across .github/workflows/ confirms this was the only static JDK
setup step whose name disagreed with its configured java-version; every
other step either pins 11 with a matching name or derives the version
from the build matrix.

### What type of PR is it?
Improvement

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6486

### How should this be tested?
grep -rn "Set up JDK 8" .github/workflows/ returns no matches.
The renamed step still has java-version: 11 and no other keys changed.

### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants