[ZEPPELIN-6602] Add a transport-neutral interpreter RPC contract harness - #5375
Draft
jongyoul wants to merge 2 commits into
Draft
[ZEPPELIN-6602] Add a transport-neutral interpreter RPC contract harness#5375jongyoul wants to merge 2 commits into
jongyoul wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This is the first test-only slice (G-01A) of ZEPPELIN-6601, the Server–Interpreter RPC migration Epic.
The earlier draft characterized only the current Thrift wire. This revision establishes the reusable behavioral regression seam that later transport PRs will consume:
InterpreterRpcContractDriverdefines transport-neutral request/result values, lifecycle operations, probe hooks, fault hooks, and semantic failure categories.AbstractInterpreterRpcContractTestowns the common control-plane scenarios.InterpreterRpcContractFixtureexposes the same executable Interpreter fixture and probe handle to future transport modules.zeppelin-interpreterpublishes these test sources in itstestsclassifier JAR.ThriftInterpreterRpcContractDriverruns the common scenarios through realTSocket/TBinaryProtocolconnections and the generated client/processor.TTransportExceptionand declaredInterpreterRPCExceptionassertions.The shared scenarios cover:
The common scenario/API sources import no Thrift or generated transport types. The executable fixture temporarily references
InterpreterCompletiononly because it is still part of the publicInterpreterAPI; G-02 removes that API leak without changing the shared scenario bodies. The Thrift adapter and wire smoke are temporary and are removed with Thrift, while the common suite and fixture remain for gRPC.Out of scope: production gRPC or production API changes, callback/event RPCs, pooled-client retry/deadlines, shutdown ambiguity, recovery, launchers, process registration, and shaded-distribution checks. Those have separate child Tasks under the Epic.
What type of PR is it?
Improvement
Todos
zeppelin-interpreterverificationWhat is the Jira issue?
How should this be tested?
Local results:
zeppelin-interpretermodule: 131 passedzeppelin-interpreter-0.13.0-SNAPSHOT-tests.jarproducedScreenshots (if appropriate)
Not applicable.
Questions: