fix(sklearn): rename SVR shrinking parameter - #7973
Conversation
Backport auto-label reportThis
|
Automated Reviewer SuggestionsBased on the
|
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🟢 | bs=10 sw=10 sl=64 | 434 | 0.265 | 22,382/34,535/34,535 us | 🟢 -8.4% / 🔴 +145.5% |
| 🔴 | bs=100 sw=10 sl=64 | 905 | 0.552 | 105,925/146,313/146,313 us | 🔴 +11.0% / 🔴 +51.6% |
| 🔴 | bs=1000 sw=10 sl=64 | 1,090 | 0.665 | 914,074/1,046,122/1,046,122 us | 🔴 +11.7% / 🔴 +12.5% |
Baseline details
Latest main 2c2c0e5 from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 434 tuples/sec | 425 tuples/sec | 863.81 tuples/sec | +2.1% | -49.8% |
| bs=10 sw=10 sl=64 | MB/s | 0.265 MB/s | 0.259 MB/s | 0.527 MB/s | +2.3% | -49.7% |
| bs=10 sw=10 sl=64 | p50 | 22,382 us | 24,443 us | 11,488 us | -8.4% | +94.8% |
| bs=10 sw=10 sl=64 | p95 | 34,535 us | 33,438 us | 14,067 us | +3.3% | +145.5% |
| bs=10 sw=10 sl=64 | p99 | 34,535 us | 33,438 us | 17,591 us | +3.3% | +96.3% |
| bs=100 sw=10 sl=64 | throughput | 905 tuples/sec | 968 tuples/sec | 1,127 tuples/sec | -6.5% | -19.7% |
| bs=100 sw=10 sl=64 | MB/s | 0.552 MB/s | 0.591 MB/s | 0.688 MB/s | -6.6% | -19.8% |
| bs=100 sw=10 sl=64 | p50 | 105,925 us | 102,257 us | 89,893 us | +3.6% | +17.8% |
| bs=100 sw=10 sl=64 | p95 | 146,313 us | 131,868 us | 96,506 us | +11.0% | +51.6% |
| bs=100 sw=10 sl=64 | p99 | 146,313 us | 131,868 us | 104,915 us | +11.0% | +39.5% |
| bs=1000 sw=10 sl=64 | throughput | 1,090 tuples/sec | 1,105 tuples/sec | 1,156 tuples/sec | -1.4% | -5.7% |
| bs=1000 sw=10 sl=64 | MB/s | 0.665 MB/s | 0.675 MB/s | 0.705 MB/s | -1.5% | -5.7% |
| bs=1000 sw=10 sl=64 | p50 | 914,074 us | 909,827 us | 886,448 us | +0.5% | +3.1% |
| bs=1000 sw=10 sl=64 | p95 | 1,046,122 us | 936,542 us | 930,093 us | +11.7% | +12.5% |
| bs=1000 sw=10 sl=64 | p99 | 1,046,122 us | 936,542 us | 963,104 us | +11.7% | +8.6% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,460.91,200,128000,434,0.265,22381.85,34534.50,34534.50
1,100,10,64,20,2210.33,2000,1280000,905,0.552,105925.45,146313.44,146313.44
2,1000,10,64,20,18347.87,20000,12800000,1090,0.665,914074.17,1046122.42,1046122.42
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7973 +/- ##
============================================
+ Coverage 92.79% 92.82% +0.03%
- Complexity 4616 4735 +119
============================================
Files 1174 1175 +1
Lines 47453 48071 +618
Branches 5304 5409 +105
============================================
+ Hits 44034 44624 +590
- Misses 1899 1902 +3
- Partials 1520 1545 +25
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
What changes were proposed in this PR?
Renamed the
probabilityparameter toshrinkinginSklearnAdvancedSVRParameters.The generated Python parameter was already correctly set to
shrinking; only the displayed parameter name was incorrect.Before:


After:
Note: This renames the enum constant from
probabilitytoshrinking. Existing workflows saved withprobabilitywill need to be updated.Any related issues, documentation, discussions?
Fixes #7949
How was this PR tested?
Tested the Advanced SVM Regressor Trainer with
shrinking = trueand verified that the resulting parameters showshrinking = True.Was this PR authored or co-authored using generative AI tooling?
Generated-by: ChatGPT (5.5 GPT)