fix(nodejs): fail fast on NotFoundException during startup route fetch - #1374
Merged
RongtongJin merged 2 commits intoSep 23, 2026
Merged
Conversation
Non-not-found errors keep the 3-attempt retry with linear backoff, but NotFoundException (topic/consumer group does not exist) can never succeed on retry - surface it immediately so the error message and cause chain carry NotFoundException(40402) instead of a generic 'Failed to fetch topic routes after 3 attempts' wrapper.
zhaohai666
force-pushed
the
fix/nodejs-startup-route-fail-fast
branch
from
September 15, 2026 03:40
de7cebe to
c30f417
Compare
RockteMQ-AI
approved these changes
Sep 15, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Fail-fast on NotFoundException during startup route fetch — clean, focused fix that aligns with the Java client behavior.
The logic is correct: if the initial QueryRoute returns NotFound, retrying will never succeed, so throwing immediately is the right call. The added tsconfig.test.json is a reasonable addition for test compilation.
CI is green. LGTM.
Note: This PR and #1375/#1376 all add the same
tsconfig.test.json. If merged sequentially, the later PRs will have a merge conflict on that file. Consider coordinating the merge order or consolidating the file into one PR.
Automated review by github-manager-bot
This was referenced Sep 15, 2026
RongtongJin
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P2 fix(nodejs): fail fast on NotFoundException during startup route fetch
Startup rejects immediately when the initial
QueryRoutereturnsNotFoundException,instead of silently retrying forever. Non-not-found errors keep the 3-attempt retry
with linear backoff, so the error message and cause chain now carry
NotFoundException(40402)directly.Files:
nodejs/src/client/BaseClient.ts(1 hunk)