fix(spec): parse commit duration options and align their defaults with Java - #671
Open
jackylee-ch wants to merge 1 commit into
Open
fix(spec): parse commit duration options and align their defaults with Java#671jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit.timeout,commit.min-retry-waitandcommit.max-retry-waitaredurationType()in Java, but Rust parsed bare milliseconds only:commit.timeout = '2 min'failed to parse and silently fell back to the default, so a plausibleconfiguration was accepted and ignored. Two of the defaults also diverged —
min-retry-wait was 1000ms against Java's 10ms, and the timeout was 120000ms where
Java leaves it unset and lets
commit.max-retriesbound the loop alone. Thosecompound: Rust slept ~75s across its retry budget where Java sleeps ~10s, and could
then abandon the commit on wall clock with "there may exist commit conflicts between
multiple jobs" while Java was still retrying.
Fix: add
parse_duration_millis, mirroringTimeUtils.parseDurationand shapedlike the existing
parse_memory_size— every Java unit label, case-insensitive,bare number as millis,
Noneon overflow. Align the two defaults, usingu64::MAXas the unbounded sentinel; the value is only ever compared against elapsed time, so
no arithmetic can overflow.
Bare-millisecond values keep working, since Java reads an empty unit label as millis too.