Conversation
Assert ordered timeline text segments instead of the removed TurnViewModel.assistant aggregate. Preserve append, replacement, and snapshot immutability coverage while restoring CI compilation. Generated-by: Codex
6 tasks
6 tasks
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #5510 merged, CI and Windows recovery fail while compiling
@maka/ui: four new transcript projection assertions accessTurnViewModel.assistant, which #5559 removed.Assert the ordered text segments in
timelineinstead. This preserves coverage for appended and replaced text, and for previous projections remaining immutable snapshots.Refs #5510, #5559. Failure logs: CI, Windows recovery.
Verification
npm --workspace @maka/ui run typecheckbefore the fix.npm run build— passed.npm --workspace @maka/ui run test:dist— all 652 tests passed, including the affected projection tests.npm run lintandnpm run typecheck— passed.apps/desktopandpackages/ui— passed.packages/uiis formatter-excluded by repository configuration.git diff --check— passed.Windows recovery was not run locally (macOS); the existing Windows failure occurs in the shared TypeScript compilation step.
AI use
Select exactly one:
Tool(s) and scope: Codex diagnosed the CI failure, updated the assertions, ran verification, and prepared this PR at the contributor's request. The commit includes
Generated-by: Codex.Checklist
Does this PR entail a change in behavior?