Conversation
…n tests apache#5510 added assertions on `TurnViewModel.assistant`, which apache#5559 had already removed, so `tsc -p packages/ui` fails on main and every job that builds @maka/ui fails with it. The answers now come from the turn's text timeline items. Each assertion keeps what it proved: the earlier snapshot still holds only the original answer, and the appended step shows up as its own text item. Generated-by: Claude Code
Contributor
Author
|
Folded into #5638, which needs the same fix to go green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tsc -p packages/uifails on main, and so does every CI job that builds@maka/ui, including the merge ref of every open PR (for example package-linux on #5638, run 35985262613):#5510 added assertions on
TurnViewModel.assistant, which #5559 had already removed; each PR passed on its own base. The assertions now read the turn's answers from itstexttimeline items, and each one still proves what it did: the earlier snapshot holds only the original answer, and the appended step shows up as its own text item.Verification
npm --workspace @maka/ui run build: no type errors.node --test dist/__tests__/transcript-projection.test.jsinpackages/ui: 26 pass.npm run format,npm run lint.AI use
Tool(s) and scope: Claude Code: diagnosis, the test fix, and this description.
Checklist
Does this PR entail a change in behavior?