Skip to content

fix(desktop): stabilize session switching layout - #5689

Closed
Colafornia wants to merge 1 commit into
apache:mainfrom
Colafornia:fix/session-switch-stability
Closed

Colafornia wants to merge 1 commit into
apache:mainfrom
Colafornia:fix/session-switch-stability

Conversation

@Colafornia

@Colafornia Colafornia commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Keep live usage and permission controls mounted while switching sessions, so async reads do not reflow the composer footer.
  • Reserve the chat scrollbar gutter with stable both-edges, preventing the composer from shifting when the transcript scrollbar appears or disappears.
  • Keep the Permission icon visually stable while its action is temporarily disabled during boundary reads.
  • Scope usage reads to the active session, model, and provider; show pending state instead of stale usage.

Before / After

State Video
Before Paste video here
After Paste video here

Verification

  • npm run build passed.
  • npm run lint passed.
  • npm run format:check passed.
  • npm --workspace @maka/desktop run build-storybook passed.
  • Full npm test was attempted; several environment-dependent suites failed because the local runner cannot open required sockets and file watchers (listen EPERM, EMFILE).
  • Storybook smoke was attempted with elevated permissions; all but one unrelated existing model-picker assertion passed.

AI use

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Codex contributed to the implementation, tests, and review.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, build, and affected checks were run locally

Does this PR entail a change in behavior?

  • Yes - the session-switch footer remains stable while data resolves
  • No

@github-actions github-actions Bot added the effort/L Under 1000 readable lines label Sep 24, 2026
@Colafornia
Colafornia force-pushed the fix/session-switch-stability branch 2 times, most recently from d9f3f06 to b61eede Compare September 24, 2026 12:55
@Colafornia
Colafornia force-pushed the fix/session-switch-stability branch from b61eede to 4ab93ce Compare September 24, 2026 13:44
@Colafornia

Copy link
Copy Markdown
Member Author

Closing this PR because most of its changes duplicate the fixes already landed in #5683, while the remaining changes address issues that could not be reproduced.

@Colafornia Colafornia closed this Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/L Under 1000 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant