-
Notifications
You must be signed in to change notification settings - Fork 529
feat(connections)!: unify custom connections with per-model protocols #5684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Astro-Han
merged 16 commits into
apache:main
from
Astro-Han:feat/5673-unified-custom-connection
Sep 24, 2026
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8f7ec8f
feat(connections)!: unify custom connections with per-model protocols
Astro-Han 68957e6
fix(runtime-host): bump the compatibility epoch for the custom connec…
Astro-Han 179b31e
fix(ui): keep the custom connection protocol in the add form's endpoi…
Astro-Han f69a20d
fix(runtime-host): reject reusing a custom connection on another prot…
Astro-Han b983403
fix(storage): read migrated custom connections that have no base URL
Astro-Han 47a7faa
fix(runtime): send minimal thinking as low effort on custom Messages
Astro-Han 391243a
fix(storage): keep hosted web search on migrated anthropic-compatible…
Astro-Han cb4ebf2
refactor(config): skip legacy custom types on config import instead o…
Astro-Han e8fec7a
fix(core): put requireBaseUrl back on custom, not opencode
Astro-Han 5c13db2
fix(desktop): overwrite a custom import in place when only its protoc…
Astro-Han 29458e7
fix(runtime-host): compare the requested model's protocol when reusin…
Astro-Han b6c5cfe
fix(storage): keep hosted search for a listed but disabled deepseek-v…
Astro-Han d89a6dc
fix(runtime-host): match a hosted target on the connection default pr…
Astro-Han 43d3e75
Merge remote-tracking branch 'origin/main' into feat/5673-unified-cus…
Astro-Han 8685af2
test(runtime): expect the refreshed Vercel GPT-5.1 thinking efforts
Astro-Han 006796c
fix(storage): skip an import overwrite that would change a custom pro…
Astro-Han File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Do not report a protocol-mismatched snapshot as overwritten while retaining the old protocol
Creation now restores
defaultApiProtocol, but the overwrite branch above cannot apply it: that field is fixed at creation (packages/core/src/runtime-policy.ts:293-294), and catalog updates copyprevious.defaultApiProtocol(packages/storage/src/runtime-policy/connection-catalog-document.ts:358-367). The importer nevertheless counts the item as overwritten and replaces its endpoint, selection, and override table. On this exact head, importing anopenai-responsessnapshot over an existingopenai-chatconnection changed the base URL to the source value but returned and storedopenai-chat. The restored connection is therefore a hybrid that does not match the backup and can send unoverridden models on the wrong wire. Please reject/skip this conflict explicitly, or replace/migrate it atomically while preserving credentials.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 006796c:
planConnectionMergenow skips an overwrite whose existing custom connection has a differentdefaultApiProtocol, so the import neither produces a hybrid nor writes the bundle's credential onto it. Replacing it would drop credentials a connection-only backup cannot restore; the user can remove the connection and import again to take the snapshot's protocol.