Skip to content

fix(desktop): stop Daily Review transition flash - #5314

Open
liuxiaocs7 wants to merge 1 commit into
apache:mainfrom
liuxiaocs7:fix/daily-review-transition-flicker
Open

liuxiaocs7 wants to merge 1 commit into
apache:mainfrom
liuxiaocs7:fix/daily-review-transition-flicker

Conversation

@liuxiaocs7

Copy link
Copy Markdown
Member

Summary

Switching from Scheduled Tasks to Daily Review briefly showed a full-page lazy-loading spinner, followed by Daily Review's own skeleton and a 150 ms opacity animation. Load DailyReviewPanel with the Module Hub and remove the redundant entry animation so the transition proceeds directly through the stable Daily Review loading state.

Fixes #5313

Before:

Daily Review showing the transient lazy-loading spinner

After:

Daily Review rendered without the transition flash

Verification

  • npm run lint
  • npm run format:check
  • npm run build
  • npm run typecheck
  • npx knip --workspace apps/desktop
  • npx knip --workspace packages/ui
  • Focused Module Hub Storybook run: 6/6 passed
  • npm --workspace @maka/desktop run build-storybook
  • npm --workspace @maka/desktop run smoke:storybook: 360 stories / 389 renders passed
  • Reverse regression check: restoring the previous lazy panel and entry animation made the new transition assertion fail (1 animation observed, expected 0); the fixed implementation passes.
  • npm run check:asf-headers is blocked by pre-existing untracked files under docs/ outside this change. The staged commit hook's ASF header audit passed for the files in this PR.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Codex diagnosed the transition sequence, implemented the UI fix and Storybook regression coverage, and prepared the contribution artifacts.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@github-actions github-actions Bot added the effort/S Under 100 readable lines label Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/S Under 100 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Daily Review flashes while switching from Scheduled Tasks

1 participant