fix(desktop): stop Daily Review transition flash - #5314
Open
liuxiaocs7 wants to merge 1 commit into
Open
liuxiaocs7 wants to merge 1 commit into
liuxiaocs7 wants to merge 1 commit into
Conversation
Generated-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switching from Scheduled Tasks to Daily Review briefly showed a full-page lazy-loading spinner, followed by Daily Review's own skeleton and a 150 ms opacity animation. Load
DailyReviewPanelwith the Module Hub and remove the redundant entry animation so the transition proceeds directly through the stable Daily Review loading state.Fixes #5313
Before:
After:
Verification
npm run lintnpm run format:checknpm run buildnpm run typechecknpx knip --workspace apps/desktopnpx knip --workspace packages/uinpm --workspace @maka/desktop run build-storybooknpm --workspace @maka/desktop run smoke:storybook: 360 stories / 389 renders passed1animation observed, expected0); the fixed implementation passes.npm run check:asf-headersis blocked by pre-existing untracked files underdocs/outside this change. The staged commit hook's ASF header audit passed for the files in this PR.AI use
Select exactly one:
Tool(s) and scope: Codex diagnosed the transition sequence, implemented the UI fix and Storybook regression coverage, and prepared the contribution artifacts.
Checklist
Does this PR entail a change in behavior?