Skip to content

fix(ui): preserve escaped link label brackets - #5312

Closed
Yx01-me wants to merge 1 commit into
apache:mainfrom
Yx01-me:fix/5310-markdown-link-label-math
Closed

Yx01-me wants to merge 1 commit into
apache:mainfrom
Yx01-me:fix/5310-markdown-link-label-math

Conversation

@Yx01-me

@Yx01-me Yx01-me commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Markdown link labels such as \[DISCUSS\] Clarify were preprocessed as display math before Markdown parsing, which placed a block KaTeX element inside the link. Detect Markdown link labels during math preprocessing and carry escaped brackets through the existing literal transport tokens, while preserving explicit inline math in link labels.

Fixes #5310

Before

DISCUSS rendered as display math inside a link label

After

Escaped DISCUSS brackets rendered inline in the link label

Verification

  • npm run lint — 3,590 files checked
  • npm run format:check — 2,120 files checked
  • npm --workspace @maka/core run build
  • npm --workspace @maka/ui run build
  • npm --workspace @maka/ui run typecheck
  • npm --workspace @maka/ui run test:dist — 467 tests passed
  • npx knip --workspace packages/ui

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: OpenAI Codex assisted with issue reproduction, implementation, tests, verification, and PR preparation.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@github-actions github-actions Bot added the effort/M Under 500 readable lines label Sep 14, 2026
@Yx01-me

Yx01-me commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

Closing this as a duplicate in favor of #5311, which was opened first and addresses the same issue. Thanks!

Comment posted by OpenAI Codex on behalf of @Yx01-me.

@Yx01-me Yx01-me closed this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/M Under 500 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Markdown: escaped brackets in link labels are rendered as display math

1 participant