Conversation
Keep the scrolling editable at least one line plus its block padding through inert session transitions. Cover draft restoration, empty disabled states, multiline scrolling, send-clear, and compact WorkHub geometry. Refs apache#5264 Generated-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the clipped insertion caret in an empty composer after switching between WorkHub and sidebar conversations.
Keep the scrolling editable at least one line tall, including its vertical padding. Share the padding value with compact WorkHub so both layouts retain enough space for the caret.
Preserve the existing interaction gate, editor DOM, draft restoration and multiline scrolling. Add regression coverage to the existing EmptyHome and ProgressModelPicker stories.
Fixes #5264
Verification
6bff26b42: EmptyHome collapses to 8px instead of at least 30px; compact WorkHub measures 22px instead of at least 34px. All three focused browser cases pass with the fix.Before/after layout evidence (the browser assertions above verify the editable height; these screenshots are not native caret-pixel assertions):
Before:
After:
AI use
Tool(s) and scope: OpenAI Codex — implementation, regression tests, and validation; reviewed by the author.
Checklist
Does this PR entail a change in behavior?