Repository navigation
[Bug] numRows(0) stops reading instead of disabling the row limit #1149
Description
Fesod version
Current main at 5a9a16b.
Description
The documentation defines numRows = 0 as unlimited, but the default ReadListener#hasNext treats zero as an active limit and stops before delivering the first row.
Location
fesod-sheet/src/main/java/org/apache/fesod/sheet/read/listener/ReadListener.java:101-106website/docs/sheet/read/num-rows.md:32website/docs/sheet/help/parameter.md:163,175
Reproduction
Reading the same three-row workbook produced these results:
no numRows setting: 3 rows
numRows(0): 0 rows
numRows(1): 1 row
At row index 0, the current condition limit != null && index >= limit evaluates to true for a zero limit.
Expected behavior
numRows(0) should behave like no row limit, as documented, across XLSX, XLS, and CSV.
Suggested fix
Apply the limit only when it is positive and add a parameterized regression test for all supported read formats.
Related existing work
Issues #151, #661, and #937 cover other numRows behavior, primarily callbacks and multi-sheet reads. They do not cover the documented zero sentinel.
Are you willing to submit a PR?
Yes.
Activity
BigDataDZ commentedon Oct 7, 2026
Claiming this one - PR: #1189. The fix applies the limit only when positive, and the new parameterized test covers the zero sentinel, the omitted setting and a positive limit across XLSX/XLS/CSV.
bengbengbalabalabeng commentedon Oct 8, 2026
Thank you for your interest. There is already a corresponding fix PR (#1159) for this issue. If you'd like, you're also welcome to review it or add further comments to the discussion here.
fix: treat numRows zero as unlimited (#1159)