Fix DDC reconciliation for FDB ConfigMap changes - #517
Open
Al-assad wants to merge 1 commit into
Open
Conversation
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Related PR: N/A
Problem Summary:
A
DorisDisaggregatedClusterreads the FoundationDBcluster-fileConfigMap only while reconciling, but the DDC controller does not watch that referenced ConfigMap. When fdb-kubernetes-operator changes the cluster file for a healthy cluster, the MetaService StatefulSet can therefore keep the oldFDB_ENDPOINTuntil another watched resource changes or the controller-runtime cache performs its periodic resync.This change watches ConfigMap
cluster-filecreate, update, and delete events, maps them to DDCs that reference the ConfigMap, and immediately reconciles those DDCs. Metadata-only ConfigMap updates and DDCs using a direct FDB address are ignored. FDB endpoint resolution now fails before constructing the desired StatefulSet, so a missing or invalid ConfigMap cannot remove the currently deployedFDB_ENDPOINT.Release note
Changes to an fdb-kubernetes-operator
cluster-fileConfigMap now promptly update and roll out the referencing MetaService StatefulSet.Check List (For Author)
Test commands:
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)