Remove smoke test group - #152
Conversation
|
|
||
| -- FDW test | ||
| CREATE SERVER hive_smoke_test_server | ||
| FOREIGN DATA WRAPPER hive_pxf_fdw |
There was a problem hiding this comment.
Could we keep this test until there is an FDW-enabled replacement? The existing Hive automation tests are not currently exercised in FDW mode: at the current PR head, the features_fdw report shows all 37 HiveTest cases as skipped. Removing this file therefore drops the end-to-end coverage that creates hive_pxf_fdw and reads from a real Hive table. Please port at least this basic Hive FDW read case to the automation or Testcontainers suite before deleting it.
| OPTIONS (resource '{{ HCFS_BUCKET }}{{ TEST_LOCATION }}', format 'csv'); | ||
|
|
||
| -- write to writable table | ||
| INSERT INTO multi_block_data_smoke_test_foreign_table |
There was a problem hiding this comment.
Could we port the write side of this test before deleting it? The new MultiBlockDataTest is not equivalent: it copies a generated file into HDFS and reads it through a ReadableExternalTable in the load group. It never performs this 32-million-row insert through FDW or checks the per-segment distribution. HdfsWritableTextTest exercises FDW writes, but only with 100 rows, so the large multi-block write path remains uncovered. Please retain this test or add an FDW-enabled large-write replacement.
2 participants
There are two motivations behind this PR:
In this PR
/regression/tests (or move it to automation tests).