Repository navigation
fix: identify the SQLx adapter crate as part of Casbin - #116
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 1.9.0 RC1 review asks for a crate name that identifies Casbin. This change proposes
casbin-sqlx-adapter, updates the registry/docs links, installation examples, release notes and release-script fixture, and corrects the SQLx display spelling.An explicit
[lib] name = "sqlx_adapter"preserves Rust imports and theSqlxAdapterpublic type. The README explains the dependency-name migration and when the new registry links become available. Production code, feature support, dependency versions and ASF source-archive naming are unchanged.Validation:
cargo package --locked --allow-dirtyincluding package verification pass. A separate consumer compiles against the extracted crate usingsqlx_adapter::SqlxAdapter.The proposed registry name returned 404 when checked; that does not reserve it or establish project ownership. Confirm the name and project publishing administration before the new release. No registry package or new release candidate is published by this change.