Make streaming failures fail closed by default - #889
Open
Eilen6316 wants to merge 1 commit into
Open
Conversation
Author
|
CI note: the documentation workflow concluded with startup_failure before creating any jobs or logs. Recent unrelated PRs show the same startup_failure for .github/workflows/docs.yml. A local Sphinx dirhtml build completed successfully for this branch. The remaining Build Burr, Release Validation, and Build Sphinx Documentation workflows are marked action_required and need maintainer approval for this fork PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a fail-closed default for sync and async streaming actions, requires explicit StreamingFailurePolicy.COMMIT_PARTIAL for partial commits, propagates the policy through all streaming entry points, and adds regression tests and documentation. Tests: 396 core tests passed; Graphviz display tests require optional local Graphviz dependencies.