[Hotfix][AMS] Fix optimizer registration failure under database HA mode - #4352
Open
wangxianghu wants to merge 1 commit into
Open
[Hotfix][AMS] Fix optimizer registration failure under database HA mode#4352wangxianghu wants to merge 1 commit into
wangxianghu wants to merge 1 commit into
Conversation
Author
|
hi @zhoujinsong could you please take a look when free ? this is simple bug fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
When HA is enabled with ha.type=database, AmsUtil.getAMSThriftAddress still takes the ZooKeeper branch because it only checks ha.enabled. This makes it build a zookeeper://... address from ha.zookeeper-address, which is not configured in database-HA deployments. The bad URI is injected into the optimizer as ams.optimizer.uri, so the optimizer cannot reach AMS and fails to register.
The fix narrows the ZooKeeper branch to ha.enabled && ha.type == zk. For database HA (and non-HA), it now returns the direct thrift://: address, which is the same host/port the AMS node registers under its lease, so the optimizer registers correctly.
Brief change log
How was this patch tested?
Documentation