Skip to content

ci: use W3C-compliant Sauce Labs tunnelName and remove deprecated tunnelIdentifier - #33723

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:fix-saucelabs-w3c-tunnel
Jul 31, 2026
Merged

ci: use W3C-compliant Sauce Labs tunnelName and remove deprecated tunnelIdentifier#33723
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:fix-saucelabs-w3c-tunnel

Conversation

@alan-agius4

@alan-agius4 alan-agius4 commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Starting July 31, 2026, Sauce Labs servers will no longer support Sauce Connect 4 traffic. During the upgrade to Sauce Connect 5 (saucelabs/sauce-connect-action@v3), passing both tunnelIdentifier and tunnelName caused Sauce Labs W3C WebDriver session creation to fail with:

Both desired capabilities 'tunnelIdentifier' and 'tunnelName' were provided at the same time. Since 'tunnelIdentifier' is deprecated, please only use 'tunnelName' for specifying your Sauce Connect tunnel name.

This commit removes the deprecated tunnelIdentifier capability from both the top-level capability object and 'sauce:options', only passing tunnelName inside 'sauce:options' to ensure 100% W3C WebDriver specification compliance for Sauce Connect 5.

@angular-robot angular-robot Bot added the area: build & ci Related the build and CI infrastructure of the project label Jul 31, 2026
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jul 31, 2026
@alan-agius4
alan-agius4 force-pushed the fix-saucelabs-w3c-tunnel branch 2 times, most recently from 9f8af3f to 01884a2 Compare July 31, 2026 21:43
@alan-agius4
alan-agius4 marked this pull request as ready for review July 31, 2026 21:43
@alan-agius4
alan-agius4 requested a review from dgp1130 July 31, 2026 21:43
@alan-agius4
alan-agius4 marked this pull request as draft July 31, 2026 21:43
@alan-agius4
alan-agius4 removed the request for review from dgp1130 July 31, 2026 21:44

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Protractor Sauce Labs configuration by explicitly mapping W3C capabilities and cleaning up the tunnel configuration properties. The reviewer suggested a more robust approach to mapping capabilities by destructuring and spreading the remaining properties to prevent silently dropping other standard or browser-specific capabilities in the future.

Comment thread tests/e2e/assets/protractor-saucelabs.conf.js
@alan-agius4
alan-agius4 force-pushed the fix-saucelabs-w3c-tunnel branch from 01884a2 to b03ee7b Compare July 31, 2026 21:52
@alan-agius4
alan-agius4 marked this pull request as ready for review July 31, 2026 21:53

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Protractor Saucelabs configuration by explicitly mapping browser capabilities and simplifying the tunnel identifier properties. The reviewer recommends using object destructuring with the rest operator to avoid silently dropping other browser-specific options or custom capabilities that may be present in the capabilities array.

Comment thread tests/e2e/assets/protractor-saucelabs.conf.js
@alan-agius4
alan-agius4 force-pushed the fix-saucelabs-w3c-tunnel branch from b03ee7b to 25c1a1b Compare July 31, 2026 21:57
@alan-agius4
alan-agius4 requested a review from dgp1130 July 31, 2026 22:00
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 31, 2026
@alan-agius4
alan-agius4 removed the request for review from dgp1130 July 31, 2026 22:10
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 31, 2026
@alan-agius4
alan-agius4 merged commit 1c2a17e into angular:main Jul 31, 2026
41 checks passed
@alan-agius4
alan-agius4 deleted the fix-saucelabs-w3c-tunnel branch July 31, 2026 22:20
@alan-agius4

Copy link
Copy Markdown
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants