Skip to content

WIP: sdhci-dwc: adsp-sc598: consume emmc_timer_cmq clock - #3487

Draft
sipraga wants to merge 1 commit into
adsp-6.18.31-yfrom
alvin/adsp/fix-mmc-clock-race
Draft

WIP: sdhci-dwc: adsp-sc598: consume emmc_timer_cmq clock#3487
sipraga wants to merge 1 commit into
adsp-6.18.31-yfrom
alvin/adsp/fix-mmc-clock-race

Conversation

@sipraga

@sipraga sipraga commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Fixes an odd race. Need to understand when/why this clock is needed.

To reproduce: build with CONFIG_MMC_SDHCI_OF_DWCMSHC=m and boot rootfs over NFS. Then mmc will probe much later than the disabling of unused clocks. emmc_timer_cmq is then disabled and you hit the error.

Another issue: the clock in the DT headers is mislabelled QMC. Also in the clock driver. To fix...

PR Description

  • Please replace this comment with a summary of your changes, and add any context
    necessary to understand them. List any dependencies required for this change.
  • To check the checkboxes below, insert a 'x' between square brackets (without
    any space), or simply check them after publishing the PR.
  • If you changes include a breaking change, please specify dependent PRs in the
    description and try to push all related PRs simultaneously.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have compiled my changes, including the documentation
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly
  • I have provided links for the relevant upstream lore

Fixes an odd race. Need to understand when/why this clock is needed.

To reproduce: build with CONFIG_MMC_SDHCI_OF_DWCMSHC=m and boot rootfs
over NFS. Then mmc will probe much later than the disabling of
unused clocks. emmc_timer_cmq is then disabled and you hit the error.

Another issue: the clock in the DT headers is mislabelled QMC. Also in
the clock driver. To fix...
@sipraga
sipraga requested a review from ukleinek August 11, 2026 16:06
@sipraga

sipraga commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Need to learn more about this clock before merging. Just putting this here as a fix in case people are blocked.

@pamolloy pamolloy added this to ADSP Aug 14, 2026
@pamolloy

Copy link
Copy Markdown
Collaborator

Would also be good to write a hardware test for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants