Skip to content

ci(release): ignore example-only changes - #569

Merged
christso merged 1 commit into
mainfrom
ci/release-ignore-example-only
Oct 16, 2026
Merged

christso merged 1 commit into
mainfrom
ci/release-ignore-example-only

Conversation

@christso

@christso christso commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Example-only changes should not propose a new CLI release. #567 used a fix title and touched example files plus their test, so Release Please proposed #568 even though no shipped CLI code changed. Exclude commits confined to examples/ and tests/ from release calculations; mixed commits touching CLI source, build scripts, or root dependencies stay eligible according to their conventional commit type. Document chore(examples) and docs(examples) for example-only changes.

Validation:

  • All CI checks passed, including the full test suite, build, docs, lint, typecheck, Node 24, and Windows checks.
  • Release Please succeeded on merged main, created no release PR, and skipped publication because there was no open pending release. The open pending-release PR inventory is empty.
  • Replayed actual main history through Release Please 17.6.0, matching the dependency locked into googleapis/release-please-action@v5. Before the change it proposed one release PR, 1.21.1; with the local config overlay it proposes zero. This was read-only Manifest.buildPullRequests(); no tags, releases, versions, changelog files, or PRs were written by the replay.
  • Used the upstream commit detector to check seven scenarios: example-only, exact fix(workspace): unpin Compound Engineering in engineering example #567 with tests, test-only, mixed CLI/example, mixed CLI/test, root dependency changes, and a similarly prefixed directory. All passed; mixed/product changes remain eligible.
  • bun test tests/unit/scripts/publish.test.ts: 5 passed. Typecheck, lint, build, and git diff --check passed.
  • Focused code review and an independent adversarial review: ready to merge, no actionable findings. The real-history replay was independently rerun with the same passing result. Review run: 20261016-105957-release-policy.
  • No new repository dependency or permanent test was added for this configuration change. The upstream implementation replay supplies the behavior check instead of duplicating third-party filtering logic.

Manual replay command:

bun /tmp/allagents-release-policy-check/check.ts "$PWD"

The scratch harness loads the action's exact Release Please version, overlays the local release-please-config.json through GitHub.getFileJson, and otherwise reads actual GitHub history and the existing release manifest. Evidence:

Release Please 17.6.0: actual main-history release candidates: 0
PASS: exact #567 with its test is excluded
PASS: mixed CLI and example fix remains release eligible
PASS: mixed CLI and test fix remains release eligible
PASS: root dependency update remains release eligible

Related: #568, #567.

Closed #568 separately: Release Please leaves an existing release PR open when the new filter produces zero candidates, and an open pending-release PR would still let the preview job publish unnecessarily.


Compound Engineering

Exclude commits limited to examples and tests from release calculations while
retaining mixed CLI changes. Document non-release titles for example changes.
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying allagents with  Cloudflare Pages  Cloudflare Pages

Latest commit: 185cc90
Status: ✅  Deploy successful!
Preview URL: https://6be0c330.allagents.pages.dev
Branch Preview URL: https://ci-release-ignore-example-on.allagents.pages.dev

View logs

@christso
christso merged commit 4084a61 into main Oct 16, 2026
8 checks passed
@christso
christso deleted the ci/release-ignore-example-only branch October 16, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant