Repository navigation
Fix infinite refinement loop in Maple interface - #382
Merged
Merged
Conversation
RootFinding[RefineRoot] was called without a digits option, so once an isolating interval was finer than the precision implied by Digits, it returned the same interval forever. SplitAndRefinePerConstraints (and RefineSolutions) then looped without ever resolving the sign of constraints that take tiny nonzero values at a solution. The required precision, already computed in prec, is now passed to RefineRoot. Also return the refined box instead of the original coarse one in SplitAndRefinePerConstraints, so that returned solutions are consistent with the returned constraint values. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RootFinding[RefineRoot] was called without a digits option, so once an isolating interval was finer than the precision implied by Digits, it returned the same interval forever. SplitAndRefinePerConstraints (and RefineSolutions) then looped without ever resolving the sign of constraints that take tiny nonzero values at a solution. The required precision, already computed in prec, is now passed to RefineRoot.
Also return the refined box instead of the original coarse one in SplitAndRefinePerConstraints, so that returned solutions are consistent with the returned constraint values.
This PR has been done with the help of Claude Opus 5.5