Repository navigation
Fix test job failure by deferring optional sentence_transformers loading - #1
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job 'test'
Fix test job failure by deferring optional Jun 16, 2026
sentence_transformers loading
aleehydar
marked this pull request as ready for review
June 16, 2026 19:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testGitHub Actions job failed during test collection becauseapp.services.ingestion_serviceimportedsentence_transformersat module import time. In CI environments where that package is unavailable, this prevented the test suite from starting.Root cause addressed: remove import-time hard dependency
SentenceTransformerimport from module scope intoget_embedder().TYPE_CHECKINGso runtime import is deferred but signatures remain explicit.Startup resilience for optional embedder dependency
ModuleNotFoundErroraround embedder warm-up.sentence_transformersis absent, instead of failing process initialization.Regression coverage for deferred import behavior
get_embedder()failure-path deferral semantics,get_embedder()success-path initialization whensentence_transformersis available.