Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec conformance hardening
Verifies every published module against the aep-spec drafts, fixes the
non-conformance and the defects found along the way, and raises coverage
from 87 tests to 493. Where the Node SDK and the drafts disagreed, the
drafts decided.
Headline fixes
AepOpenApi.resolveSecuritydid not exist, so OpenAPI securityinheritance (CORE-OAS-011/013/014/015) was unimplemented.
Authorizationrather thanAEP-Authorizationwas never found (OAB-PRS-003, BSC-PRS-003); a malformedAEP presentation answered
authentication_requiredinstead ofnot_recognized(CORE-PR-038);HEADwas unsupported whereGETwas.(PLT-LIFE-002, PLT-SIGN-007, PLT-VER-004); the minted assertion's
kidwasnot bound to the issuer (PLT-SIGN-022).
no-store, the default freshnesslifetime and the post-redirect cache key; redirects forwarded an assertion
bound to the origin request.
The conformance harness could not fail. Several mappings returned
trueregardless of SDK behaviour, comparing two constants or two fields of the same
vector; some asserted the opposite of what their vector is named for.
ConformanceFalsifiabilityTestnow runs each mapping against the publishedvector and against a corrupted expectation and requires the result to flip — it
caught three of the replacements written for this PR.
./mvnw verifygreen on all 13 modules; every applicable vector passes throughthe conformance adapter for agent, platform and service.