Conversation
Ports the Oak index migration pattern forward from the stale, fork-only PR #190 onto current main, addressing all review feedback: - Dynamic -custom-N computed from the live CS environment's existing indexes instead of assuming -custom-1 (Mohit) - Type/datatype compatibility check before applying the converter's diff (Mohit) - Corrected naming-convention wording (Mohit) - Documents why this lives under migration/ rather than code-assessment, matching the guava-cache precedent (rombert) Wires oakIndex end-to-end through bpa-local-parser.js, unified-collection-reader.js, and runbook-generator.js's PATTERN_META. Verified against a real customer BPA CSV report (84 oak index paths: 61 rule violations + 23 standard modifications). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
bharat941
requested review from
Himanich,
abhishekgarg18,
akankshajain18,
pkumargaddam and
rombert
as code owners
September 8, 2026 09:12
Contributor
Tessl Plugin Lint
|
rombert
requested changes
Sep 9, 2026
rombert
left a comment
Member
There was a problem hiding this comment.
Thanks for the submission @bharat941 , please see my inline comments.
- use npx -y to resolve the index-converter tool instead of manual npm install into a scratch node_modules dir (npx caches it for future invocations) - drop the telemetry section: no such helper exists anywhere in the repo, and no other migration reference doc emits telemetry - drop the aem-guides-wknd-legacy verification section: not part of any other reference doc's format - rename the pattern-count test to avoid churn on future additions
…ion-pattern # Conflicts: # plugins/aem/cloud-service/skills/migration/SKILL.md
Contributor
Author
|
Addressed all review feedback:
Also merged Verified: |
rombert
approved these changes
Sep 17, 2026
Member
|
LGTM, thank you. @tihom88 - any comments on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the Oak index migration pattern forward from the stale, fork-only #190 onto current
main, moving it tomigration/from the start (per the guava-cache / vault-package-dependencies precedent) and addressing all outstanding review feedback from that PR:-custom-N(Mohit): the reference doc now scans the target Cloud Service environment's existing-custom-<n>indexes and computesn+1, instead of assuming the tool's raw-custom-1output is always correct.jcr:primaryType/oak:isOakIndexDefinition/typeand cross-checks JCR value types between legacy and converted definitions, flagging mismatches for manual review instead of silently applying them.<ootb-name-on-target-cloud-services>-<version>-custom-1.migration/references/only — like Dispatcher Conversion (Branch E), it wraps Adobe'saem-cs-source-migration-index-convertertool rather than re-implementing transformation rules.Changes
migration/references/oak-index.mdmigration/SKILL.md: new "Branch F — Oak Index Migration" section, routing gate, quick-start row, Step 0 strategy table rowmigration/scripts/bpa-local-parser.js: parses BPA subtypesindex.rule.violation/standard.index.modificationintooakIndexfindings, excluding_COUNT_OIDsummary rowsmigration/scripts/unified-collection-reader.js: newprocessOakIndexFromUnified, wired into the pattern tables and dispatch mapmigration/scripts/runbook-generator.js: newPATTERN_META.oakIndexentry (bpa-onlystrategy, matchingguavaCache)Test plan
node --test *.test.jsinmigration/scripts/— 109/111 pass (2 pre-existing skips), including 2 new oakIndex tests (PATTERN_METAshape, dedup +_COUNT_OIDexclusion + sub-type split)npx skills-ref validatepasses onmigration/SKILL.mdCloses discussion in #190.
🤖 Generated with Claude Code