fix(k8s): fail execs without an exit code - #422
Draft
michaelatkin31 wants to merge 1 commit into
Draft
michaelatkin31 wants to merge 1 commit into
michaelatkin31 wants to merge 1 commit into
Conversation
progys
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Kubernetes exec response marked
Successwithout an exit code currently becomes a false zero exit, and run-script steps discard genuine nonzero codes.Testing
npm run build --prefix packages/k8snpm run test --prefix packages/k8s -- --runTestsByPath tests/exec-response-test.ts tests/exec-pod-step-test.ts tests/run-script-step-exit-code-test.tsnpx tsc --project packages/k8s/tsconfig.json --noEmitnpm run lintnpm run format-checkContext
Links: Completes DDP-1522