Skip to content

fix: assert the timeout class RSC19e's budgets can actually produce #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
owenpearson merged 1 commit into from
Sep 29, 2026
Merged

fix: assert the timeout class RSC19e's budgets can actually produce #721

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/ably/rest/restrequest_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,9 @@ async def test_timeout(self):
timeout = 0.000001
ably = AblyRest(token="foo", http_request_timeout=timeout)
assert ably.http.http_request_timeout == timeout
with pytest.raises(httpx.ReadTimeout):
# `http_open_timeout` keeps its four-second default, so the request carries a
# connect budget as well as a read budget and either can be the one to expire
with pytest.raises(httpx.TimeoutException):
await ably.request('GET', '/time', version=Defaults.protocol_version)
await ably.close()

Expand Down
Loading